fix landing page

app/routes/managers.py

@@ -9,7 +9,7 @@ from datetime import datetime
 from fastapi import APIRouter, Depends, HTTPException
 from pydantic import BaseModel
 from sqlalchemy.orm import Session
-import uuid
+from sqlalchemy import func
 
 from database.connection import get_db
 from database.models import (
@@ -18,6 +18,8 @@ from database.models import (
     ParkingGuarantee, ParkingExclusion
 )
 from utils.auth_middleware import require_admin, require_manager_or_admin, get_current_user
+from utils.helpers import generate_uuid
+from app import config
 
 router = APIRouter(prefix="/api/managers", tags=["managers"])
 
@@ -54,21 +56,28 @@ class ManagerSettingsUpdate(BaseModel):
 def list_managers(db: Session = Depends(get_db), user=Depends(require_manager_or_admin)):
     """Get all managers with their managed user count and parking quota"""
     managers = db.query(User).filter(User.role == "manager").all()
-    result = []
 
-    for manager in managers:
-        managed_user_count = db.query(User).filter(User.manager_id == manager.id).count()
+    # Batch query to get managed user counts for all managers at once
+    manager_ids = [m.id for m in managers]
+    if manager_ids:
+        counts = db.query(User.manager_id, func.count(User.id)).filter(
+            User.manager_id.in_(manager_ids)
+        ).group_by(User.manager_id).all()
+        managed_counts = {manager_id: count for manager_id, count in counts}
+    else:
+        managed_counts = {}
 
-        result.append({
+    return [
+        {
             "id": manager.id,
             "name": manager.name,
             "email": manager.email,
             "parking_quota": manager.manager_parking_quota or 0,
             "spot_prefix": manager.manager_spot_prefix,
-            "managed_user_count": managed_user_count
-        })
-
-    return result
+            "managed_user_count": managed_counts.get(manager.id, 0)
+        }
+        for manager in managers
+    ]
 
 
 @router.get("/{manager_id}")
@@ -164,7 +173,7 @@ def add_manager_closing_day(manager_id: str, data: ClosingDayCreate, db: Session
         raise HTTPException(status_code=400, detail="Closing day already exists for this date")
 
     closing_day = ManagerClosingDay(
-        id=str(uuid.uuid4()),
+        id=generate_uuid(),
         manager_id=manager_id,
         date=data.date,
         reason=data.reason
@@ -217,7 +226,7 @@ def add_manager_weekly_closing_day(manager_id: str, data: WeeklyClosingDayCreate
         raise HTTPException(status_code=400, detail="Weekly closing day already exists for this weekday")
 
     weekly_closing = ManagerWeeklyClosingDay(
-        id=str(uuid.uuid4()),
+        id=generate_uuid(),
         manager_id=manager_id,
         weekday=data.weekday
     )
@@ -246,17 +255,25 @@ def remove_manager_weekly_closing_day(manager_id: str, weekly_id: str, db: Sessi
 def get_manager_guarantees(manager_id: str, db: Session = Depends(get_db), user=Depends(require_manager_or_admin)):
     """Get parking guarantees for a manager"""
     guarantees = db.query(ParkingGuarantee).filter(ParkingGuarantee.manager_id == manager_id).all()
-    result = []
-    for g in guarantees:
-        target_user = db.query(User).filter(User.id == g.user_id).first()
-        result.append({
+
+    # Batch query to get all user names at once
+    user_ids = [g.user_id for g in guarantees]
+    if user_ids:
+        users = db.query(User).filter(User.id.in_(user_ids)).all()
+        user_lookup = {u.id: u.name for u in users}
+    else:
+        user_lookup = {}
+
+    return [
+        {
             "id": g.id,
             "user_id": g.user_id,
-            "user_name": target_user.name if target_user else None,
+            "user_name": user_lookup.get(g.user_id),
             "start_date": g.start_date,
             "end_date": g.end_date
-        })
-    return result
+        }
+        for g in guarantees
+    ]
 
 
 @router.post("/{manager_id}/guarantees")
@@ -276,7 +293,7 @@ def add_manager_guarantee(manager_id: str, data: GuaranteeCreate, db: Session =
         raise HTTPException(status_code=400, detail="User already has a parking guarantee")
 
     guarantee = ParkingGuarantee(
-        id=str(uuid.uuid4()),
+        id=generate_uuid(),
         manager_id=manager_id,
         user_id=data.user_id,
         start_date=data.start_date,
@@ -308,17 +325,25 @@ def remove_manager_guarantee(manager_id: str, guarantee_id: str, db: Session = D
 def get_manager_exclusions(manager_id: str, db: Session = Depends(get_db), user=Depends(require_manager_or_admin)):
     """Get parking exclusions for a manager"""
     exclusions = db.query(ParkingExclusion).filter(ParkingExclusion.manager_id == manager_id).all()
-    result = []
-    for e in exclusions:
-        target_user = db.query(User).filter(User.id == e.user_id).first()
-        result.append({
+
+    # Batch query to get all user names at once
+    user_ids = [e.user_id for e in exclusions]
+    if user_ids:
+        users = db.query(User).filter(User.id.in_(user_ids)).all()
+        user_lookup = {u.id: u.name for u in users}
+    else:
+        user_lookup = {}
+
+    return [
+        {
             "id": e.id,
             "user_id": e.user_id,
-            "user_name": target_user.name if target_user else None,
+            "user_name": user_lookup.get(e.user_id),
             "start_date": e.start_date,
             "end_date": e.end_date
-        })
-    return result
+        }
+        for e in exclusions
+    ]
 
 
 @router.post("/{manager_id}/exclusions")
@@ -338,7 +363,7 @@ def add_manager_exclusion(manager_id: str, data: ExclusionCreate, db: Session =
         raise HTTPException(status_code=400, detail="User already has a parking exclusion")
 
     exclusion = ParkingExclusion(
-        id=str(uuid.uuid4()),
+        id=generate_uuid(),
         manager_id=manager_id,
         user_id=data.user_id,
         start_date=data.start_date,